Hacker News
new
|
past
|
comments
|
ask
|
show
|
jobs
|
submit
login
No way to prevent strangers from approving pull requests on GitHub
(
twitter.com/adamwathan
)
7 points
by
xgdgsc
on May 15, 2023
|
hide
|
past
|
favorite
|
5 comments
coolhand2120
on May 15, 2023
|
next
[–]
CODEOWNERS
https://docs.github.com/en/repositories/managing-your-reposi...
WarOnPrivacy
on May 15, 2023
|
prev
|
next
[–]
Tweet is from 2019. It this condition still in play?
dawidpotocki
on May 15, 2023
|
parent
|
next
[–]
Yes, but it doesn't count towards the minimum approve count for PR to be allowed to be merged. It's basically just a comment.
hboon
on May 15, 2023
|
parent
|
prev
|
next
[–]
It's configurable now
jossclimb
on May 15, 2023
|
prev
[–]
Very outdated, but also something that was not necessarily bad. Quite often people might be part of community and have an interest in becoming a maintainer over time, this a chance for them to also help out before giving them elevated privileges.
Guidelines
|
FAQ
|
Lists
|
API
|
Security
|
Legal
|
Apply to YC
|
Contact
Search:
https://docs.github.com/en/repositories/managing-your-reposi...